Github Copilot ghost text does not wrap long lines

parmsam commented 12 months ago

System details

RStudio Edition : Desktop 
RStudio Version : 2023.09.0+463
OS Version      :  macOS Ventura 13.4.1
R Version       : 4.3.0

Steps to reproduce the problem

Enable soft wrapping in RStudio IDE.
Copy the first paragraph and first two words of the second paragraph of Pride and Prejudice.
Paste into R or Qmd file. It should show you ghost text without soft wrapping after a few seconds.

Describe the problem in detail

Enable soft wrapping in RStudio IDE.
Copy the first paragraph and first two words of the second paragraph of Pride and Prejudice.
Paste into R or Qmd file. It should show you ghost text without soft wrapping after a few seconds.

Describe the behavior you expected

Noticed that big chunks of ghost text do not soft wrap for the RStudio Github Copilot feature. I expect the ghost text to also soft warp so that it is readable, since I cannot side scroll in soft-wrap mode. Thanks!

[x] I have read the guide for submitting good bug reports.
[x] I have installed the latest version of RStudio, and confirmed that the issue still persists.
[x] If I am reporting an RStudio crash, I have included a diagnostics report.
[x] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

ronblum commented 12 months ago

@parmsam Thank you for raising this! We'll review this as we continue our integration with Copilot.

Also, I appreciate your example. I often use the lyrics to "Cabaret" in my testing. 🙂

kevinushey commented 6 months ago

Ace implements its display of ghost text by adding a custom token here:

https://github.com/rstudio/rstudio-ace/blob/68d8258192a24f138dce58bd0c032942ade67f74/src/virtual_renderer.js#L1761

Unfortunately, the way Ace chooses to insert the ghost text does not support soft wrapping. We could try to implement a patch for this, but I'd propose this be handled upstream.

rstudio / rstudio