Find/Replace doesn't work with gsub statements

baderstine commented 2 weeks ago

System details

RStudio Edition : Desktop
RStudio Version : 024.04.0 Build 735
OS Version      : Mac OS Sonoma 14.5 (23F79)
R Version       : R version 4.3.2 (2023-10-31)

Steps to reproduce the problem

In a .Rmd file containing a gsub function call.

e.g., gsub("blah","","sdfoiwje")

In "Source" view, Edit > Replace and Find Search for "," and attempt to replace it with ", " (i.e., add a space after the comma).

Describe the problem in detail

When you click replace, it doesn't actually change anything.

Describe the behavior you expected

I would expect this code to become: gsub("blah", "", "sdfoiwje")

[x ] I have read the guide for submitting good bug reports.
[x ] I have installed the latest version of RStudio, and confirmed that the issue still persists.
[- ] If I am reporting an RStudio crash, I have included a diagnostics report.
[x ] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

ronblum commented 2 weeks ago

@baderstine Thank you for raising this! I can't reproduce this, though. Can you provide a minimal example of an R Markdown file that causes the failure? It'll help with trying to reproduce, in case I'm not using the code in a way that causes the problem.

baderstine commented 2 weeks ago

I just updated to RStudio version 2024.04.1 Build 748 and that seemed to fix it. Nevermind!

ronblum commented 2 weeks ago

@baderstine That's great! Though if the problem returns, please let us know.

baderstine commented 2 weeks ago

ah no, this is actually just me being an idiot (PEBCAK). If you try to use keyboard shortcuts for almost everything, you can get tripped up...

Steps to reproduce (On a Mac):

Command + F
search for ","
tab to replace with ", "
click "Next" button because you don't want to replace this result.
hit "enter" to replace second result - in this case, enter is actually just "clicking" next again because that was the last button pressed.

What i should have done in step 5 is hit tab a few more times to move selection over to the "replace" button and then hit enter.

ronblum commented 2 weeks ago

@baderstine Ah! Honestly, I'm sure that I've done the same, too. 🙂

Also, TIL the acronym PEBCAK.

rstudio / rstudio