Console output with missing characters when compiling Rcpp code that have errors.

franzbischoff commented 4 years ago

System details

RStudio Edition : Desktop
RStudio Version : Version 1.4.953
OS Version      : Windows 10 and WSL
R Version       : 4.0.3
Rtools          : Rtools40

Steps to reproduce the problem

Compile Rcpp code that contains errors.

Describe the problem in detail

Using RStudio (stable version too) on Windows and Rstudio server on WSL (at least), the error messages have missing characters, like in this example:

using WSL:

I tried to remove options:

Show syntax highlighting in console output
Different color for error or message output
ANSI Escape Codes (every option)

And I tried to change fonts: Lucida Console, Courier, Noto Mono, Consolas, Firacode.

The problem persists:

Without Show syntax highlighting in console output:

Plus without Different color for error or message output and Removing ANSI colors

Plus Ignoring ANSI colors:

Describe the behavior you expected

The expected output is in the image below, using the RGui or RConsole:

[x] I have read the guide for submitting good bug reports.
[x] I have installed the latest version of RStudio, and confirmed that the issue still persists.
[x] If I am reporting a RStudio crash, I have included a diagnostics report.
[x] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

kevinushey commented 4 years ago

Compile Rcpp code that contains errors.

I realize these repro steps are "obvious", but it would be helpful if you provided us with a more concrete set of steps to reproduce -- even if that was a package (e.g. on GitHub) that we could clone + checkout some specific branch to quickly open and reproduce on build.

franzbischoff commented 4 years ago

There it is:

Repo link

Clone the repo, open in Rstudio and hit Ctrl+Shit+L, or devtools::load_all(".")

You should see this ugly format in console:

ronblum commented 4 years ago

I can reproduce this on Windows 10. It is not an issue on MacOS 11.

kevinushey commented 4 years ago

@franzbischoff: awesome, thank you! We really appreciate your taking the time to make this easily reproducible.

kevinushey commented 4 years ago

FWIW, I wasn't able to reproduce at first:

I had to explicitly set:

writeLines("PKG_CXXFLAGS = -fdiagnostics-color=always", con = "src/Makevars")

to ensure colored compiler output. Were those C++ flags set by you, or do you know if they're coming from somewhere else?

franzbischoff commented 4 years ago

Not by me.

I searched for Makevars without success on:

R libraries directory
C:\Users\Franz\*
C:\Rtools40\*

I found Makevars.win on C:\Program Files\R\R-4.0.3\src\library\windlgs\src\Makevars.win with this content: PKG_LIBS=$(GRAPHAPP_LIB)

Additionally, I tried to remove as many options as I could from RStudio settings. No luck.

Plus: compiling via Rgui or R.exe, the -fdiagnostics-color=always option is not used.

franzbischoff commented 3 years ago

Setting this ENV turns the result slightly better (at least the error turns on red and little is deleted from the output):

Sys.setenv(GCC_COLORS='error=31:quote=')

Still, this seems to be a problem with the terminal handling colors. For e.g., MSYS terminal works fine.

rstudio / rstudio