search

rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.47k stars 518 forks source link

Support Pandoc 2.11 #335

Closed cderv closed 3 years ago

cderv commented 3 years ago

Pandoc 2.11 introduced this new latex environment while introducing new --citeproc argument (https://github.com/jgm/pandoc/commit/e0984a43a99231e72c02a0a716c8d0315de9abdf#diff-64a9e5fa4509dce2699276c9e39993b4474e2446c3e86941a2f78a379f8c4079) This follows a previous change we made when Pandoc 2.8 went out (https://github.com/rstudio/rticles/commit/ee529ada1ee5dc144300383aa8f88364108b6679).

This PR aims to close #333

See https://github.com/rstudio/rticles/issues/333#issuecomment-709940186 for some thoughts about the solution

cderv commented 3 years ago

the changes look good to me.

Great, so we go with the easy way and not conditional on pandoc version. Templates will have the cslreferences environment define for nothing with Pandoc 2.11+ but I guess it does not hurt

Not sure what's going on with Travis

I think it fails because of newer latex that causes issues with some articles. For now we have two problematic, and one of the issue cause pdflatex to hang and I guess this is happening on travis.

Some PR will fix this normally. Will see.

Otherwise, we should use an older binary release of TinyTex until it is fixed.

cderv commented 3 years ago

You've merged the PR that should fix one of the issue (0e8335199e6f5decd8afadd07c22781ef12f6fcb)

But as TinyTeX is cached on Travis I am not sure which version will be used at some point in master. I know it reinstalled it for checks in this PR. I am bit lost with TeX Live version in our CI workflow - it seems it is cached and so we test on older version that people could encounter.

cderv commented 3 years ago

Oh, is it possible that this is like last time : https://github.com/rstudio/rticles/issues/303 ? As all the latex package must be installed for all the templates, it takes too long for Travis ?

cderv commented 3 years ago

Forget what I said above, in fact in fails because of #329 - so I guess that is a good sign because now our CI workflow is seeing the issue.

yihui commented 3 years ago

You are correct. I just committed 1054e2b2418995e1ef669ab13a73eab1b79f6ba6 and let's see if it works.

cderv commented 3 years ago

I applied the same fix as in copernicus by pinning only the Tex package that is the culprit. We may not need to pin down the all TinyTeX.