search

rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.47k stars 518 forks source link

Fix JSS template by pinning the version of latexrelease package #337

Closed cderv closed 3 years ago

cderv commented 3 years ago

Same fix as in 36f461dc3efae883369a88086761318848e522b0 by pining the latexrelease package to older version (https://topanswers.xyz/tex?q=1416)

This should close #329 and fix the travis build https://github.com/rstudio/rticles/pull/335#issuecomment-710149989

let's see what travis think of that

cderv commented 3 years ago

So the fix indeed work for the branch : https://travis-ci.org/github/rstudio/rticles/builds/736422869

That is good to know we can pin some packages waiting for fixes upstream. I think doing that is enough and we don't need to pin the TinyTeX binary version. What do you think ?

I guess the other workflow will suceed, it is just long to run

cderv commented 3 years ago

We should also notify JSS editors about this.

Do you have a specific contact or should we write to https://www.jstatsoft.org/about/contact ?

cderv commented 3 years ago

And maybe we need to cache again... 😞 We still get the "no output timeout" from travis, and builds are taking ~30min each... https://travis-ci.org/github/rstudio/rticles/jobs/736438003#L2351

Other idea: maybe we should build a binary specific from rticles testing ?

yihui commented 3 years ago

Do you have a specific contact or should we write to https://www.jstatsoft.org/about/contact ?

Just write to that email.

Other idea: maybe we should build a binary specific from rticles testing ?

Let's try to figure out which packages are necessary (calculate the setdiff() for tinytex::tl_pkgs() before and after testing rticles, based on a fresh install of TinyTeX), and tlmgr install them in the before_install step.

cderv commented 3 years ago

OK I'll do that ! Thanks !

yihui commented 3 years ago

We really need a way to install packages in TeX Live like the mechanism of R's .libPaths(). I searched and tried a few weeks ago, but didn't figure it out. If that is possible, we only need to cache a package directory instead of the whole TinyTeX installation. I'll ask TeX Live developers later.

cderv commented 3 years ago

Oh yes that would be great. I have thought about it but I did not look into that yet as you said you would. That would solve issue with CI and latex dependencies for sure.

yihui commented 3 years ago

I'll ask TeX Live developers later.

I've asked them and unfortunately the answer is no, but one of them said this was an interesting idea.

cderv commented 3 years ago

Oh too bad ! Thanks for asking. That prevent me for spending some time on this question. Glad they find that interesting ! We may see that appear one day then. For now, we will do without.