search

rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.47k stars 518 forks source link

AMS template.tex: Fix brace in author2 #340

Closed ConorIA closed 3 years ago

ConorIA commented 3 years ago

As written, the authors block is never closed when there is no \currentaddress for author 2. I've also moved the closing $endif$ for $if(author1)$ so that we don't end up with a stray brace when no authors are specified.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

cderv commented 3 years ago

Thanks !

This looks ok to me.

IMO, this part could be rewriten to use a for loop for authors like in other template. For example:
https://github.com/rstudio/rticles/blob/6088e669160a05ecbc343c03fe7ad3ffc07c24ee/inst/rmarkdown/templates/arxiv/resources/template.tex#L17-L31

Currently, there could only be two authors for example. But maybe that is required by the template, IDK.

ping @yufree as you are the one submitted this template in the first place. FYI.

cderv commented 3 years ago

Thank you @ConorIA !

yufree commented 3 years ago

Thanks for PR! author1 is for the old AMS latex template to deal with two authors situation. As mentioned in #298 , AMS has released v5 template which will no longer need author1. However, to make the rticle AMS template work, such change is necessary. In long term, rticle AMS template will shift to new version.

cderv commented 3 years ago

Great ! I forgot about his PR!