Closed stefanocoretta closed 3 years ago
Hi! Thanks! revtex4-1
is obsolete, but it is safe to install globally because the replacement is just called revtex
so that they coexist. In the meantime, I'll work on the changes.
@stefanocoretta as it has been 8 days I am just wondering if you are waiting for a review. don't forget to undraft so we know it is ready to be merged.
Thanks!
Hi! Thanks for checking. I am still working on this. :) (Gonna be a bit slow)
No problem & no hurry!
I wanted to be sure we were on the same page. I'll come back to help if CI fail or when you'll undraft as ask for review!
Do not hesitate to ping me if needed.
Thank you @stefanocoretta !
This pull request adds
jasa_article()
.(I had to create a new PR because I rebased the branch with a fix.)
✅ - All checks on GH Actions passed.
[x] Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to jj@rstudio.com.
[x] Add the
journalname_article()
function toR/article.R
if the output format is simple enough, otherwise create a separateR/journalname_article.R
.[x] Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname/resources/template.tex
.[x] Add a skeleton article
inst/rmarkdown/templates/journalname/skeleton/skeleton.Rmd
.[x] Add a description of the template
inst/rmarkdown/templates/journalname/template.yaml
.[x] Please include the document class file (
*.cls
) if needed, but please do not include standard LaTeX packages (*.sty
) that can be downloaded from CTAN. If you are using TinyTeX or TeX Live, you can verify if a package is available on CTAN viatinytex::parse_packages(files = "FILENAME"")
(e.g., whenFILENAME
isplain.bst
, it should return"bibtex"
, which means this file is from a standard CTAN package). Please keep the number of new files absolutely minimal (e.g., do not include PDF output files), and also make examples minimal (e.g., if you need a.bib
example, try to only leave one or two bibliography entries in it, and don't include too many items in it without using all of them).[x] Update Rd and namespace (could be done by
devtools::document()
).[x] Update NEWS.
[x] Update README with a link to the newly supported journal. Please add your Github username and the full name of the journal (follow other examples in the list).
[x] Add a test to
tests/testit/test-formats.R
by adding a linetest_format("journalname")
. We try to keep them in alphabetical order.[x] Add your name to the list of authors
Authors@R
in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base: https://yihui.name/en/2018/02/bite-sized-pull-requests/
Thank you!