Open sasank89 opened 3 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.
:white_check_mark: cderv
:x: Sasank
:x: sasank89
Hi @sasank89 !
Just a friendly ping. Are you planning to keep working on this branch to add the AAAS template ?
Just in order to know what are the plan on this one.
Thanks.
Hi @sasank89,
I have merge master branch into this PR so that it is easier to start on better grounds next time you'll work on this.
Do you plan to continue this PR any time soon ?
No rush, just to know the status on this.
Hi @cderv ,
So sorry I dropped off for a few months. Unfortunately, I did not get much time to work on this the past few months. I do want to work on it and complete it. Hopefully, I will be able to do more in the coming months.
Hi @sasank89,
No problem. Take your time on it, I am in no hurry. I'll just continue to ping once in a while to get status update so that I know if this becomes stale or not.
Happy to help in any way, so please do ping me for anything that I could help with to add this article format.
Thanks for your time and work on this !
@sasank89 Just to share that there is another try at this in #486
Hi! @cderv
This is in reference to issue #320 . I have tried to do what I can. I do have some doubts which are given in
/templates/science/resources/doubts.md
. I have added my doubts in detail to the individual things below.To contribute a new article template to this package, please make sure you have done the following things (note that
journalname_article
below is only an example name):[ ] This project uses a Contributor Licence Agreement (CLA) that you'll be asked to sign when opening a PR. This is required for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). We use a tool called CLA assistant for that.
You could also, unless you have done it in any other RStudio's projects before, sign the individual or corporate contributor agreement. You can send the signed copy to jj@rstudio.com.
[ ] Add the
journalname_article()
function toR/article.R
if the output format is simple enough, otherwise create a separateR/journalname_article.R
.[ ] Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname/resources/template.tex
.[ ] Add a skeleton article
inst/rmarkdown/templates/journalname/skeleton/skeleton.Rmd
.[X] Add a description of the template
inst/rmarkdown/templates/journalname/template.yaml
.[ ] Please include the document class file (
*.cls
) if needed, but please do not include standard LaTeX packages (*.sty
) that can be downloaded from CTAN. If you are using TinyTeX or TeX Live, you can verify if a package is available on CTAN viatinytex::parse_packages(files = "FILENAME"")
(e.g., whenFILENAME
isplain.bst
, it should return"bibtex"
, which means this file is from a standard CTAN package). Please keep the number of new files absolutely minimal (e.g., do not include PDF output files), and also make examples minimal (e.g., if you need a.bib
example, try to only leave one or two bibliography entries in it, and don't include too many items in it without using all of them).[ ] Update Rd and namespace (could be done by
devtools::document()
).[ ] Update NEWS.
[ ] Update README with a link to the newly supported journal. Please add your Github username and the full name of the journal (follow other examples in the list).
[ ] Add a test to
tests/testit/test-formats.R
by adding a linetest_format("journalname")
. We try to keep them in alphabetical order.[ ] Add your name to the list of authors
Authors@R
in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.Thank you so much for any guidance to improve this and help me close this PR.