rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.46k stars 516 forks source link

Josis #382

Open Robinlovelace opened 3 years ago

Robinlovelace commented 3 years ago

To contribute a new article template to this package, please make sure you have done the following things (note that journalname_article below is only an example name):

Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base: https://yihui.name/en/2018/02/bite-sized-pull-requests/

Thank you!

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: cderv
:x: Robinlovelace
You have signed the CLA already but the status is still pending? Let us recheck it.

Robinlovelace commented 3 years ago

First pass, let's see what happens! Any feedback v. welcome.

Robinlovelace commented 3 years ago

Heads-up @cderv I think this is ready to be reviewed/merged as appropriate. The template generates nice outputs as can be seen here in this in-progress paper I'm working on: https://github.com/zonebuilders/zonebuilder/releases/download/0.0.1/zonebuilder-paper.pdf

cderv commented 3 years ago

Thanks I'll add it in the review todo 😅 I should go back to rticles next week I believe.

Robinlovelace commented 3 years ago

Thanks for all the feedback @cderv this is great and highly educational. Will look to update the PR and respond to your comments in due course.

cderv commented 2 years ago

Hi @Robinlovelace,

Friendly ping as I am going through PR for next version.

Is this something you are still planning to spend a bit of time off ?

No hurry. I just want to check the status of this PR. Thanks !

Robinlovelace commented 2 years ago

Sorry for slow reply. I still plan to do this but may be ~1 month before I get the dedicated time needed to move this forward. Looking forward to that time as it will be a learning experience!

cderv commented 2 years ago

Hi @Robinlovelace ,

Just to inform you that I took the time to merge master in this PR and fix the conflicts so that you can start on a better basis when you'll find time to continue the work.

Cheers,

nuest commented 1 year ago

Hi @Robinlovelace ! Just came across this while looking for another PR. Big JOSIS fan, so if you're still not seeing a window to take another look, I'll find time before the end of the year.

Robinlovelace commented 1 year ago

Many thanks @nuest let's do this. The PR is almost there but year, needs a bit of TLC. FYI the editors are aware and in support of this effort.

cderv commented 1 year ago

@nuest @Robinlovelace just a friendly ping to see if this is still a project. If you need my help to make JOSIS format happens, happy to schedule some time on this.

Robinlovelace commented 1 year ago

May need some help. Thanks for patience @cderv, will be worth it! JOSIS is a great open access journal and we're almost there. I will try to get some of the editorial team involved who my have comments also.