search

rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.46k stars 516 forks source link

Update CSLreferences usage in line with upstream #390

Closed BlackEdder closed 3 years ago

BlackEdder commented 3 years ago

I had a problem with my rmarkdown not compiling to pdf any more using the newest pandoc (see here for more details: https://github.com/jgm/pandoc/issues/7215). It turned out that this was due to outdate csl-refs in the elsevier template.

The first commit in this pull request fixes this in the elsevier template and this was confirmed to solve the problem for me. The second commit also fixes it in all other template files, but I have been unable to test this. The fix is very straightforward though, so I don't foresee any issues.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

cderv commented 3 years ago

Thank you ! I did not had time to look into it yet, but it seems you've fixed #383 with this PR. 🎉 Did you check if there was other modification from the template to port here ? I just need to check that before merging.

And please can you sign the CLA if you don't mind ? thank you.

BlackEdder commented 3 years ago

@dahrens was the one who did the actual detective work required ;)

I am afraid I did not check for other changes to the template. Also, not a hundred percent sure that this fix is backward compatible with all versions of pandoc, but I guess the CI should have picked that up.

cderv commented 3 years ago

Yep CI should have pick that up. I think we're good. I'll merge this and do the other change.

I really need to improve how we keep update the template in this repo based on the ones in the other repo. Or I need to find a way to maybe patch the template base on the one shipped with a pandoc version. Anyway, this another issue.

Thank you, and really sorry for the trouble!

We are testing with pandoc devel now, so we'll try to detect this earlier and fix it as soon as our CI find the issue.