search

rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.46k stars 516 forks source link

resolve conflict between lipic format and bookdown regarding environment #392

Closed cderv closed 3 years ago

cderv commented 3 years ago

This follows https://github.com/rstudio/rticles/pull/288#issuecomment-721232934 and https://github.com/rstudio/bookdown/issues/1001

and the new option in dev bookdown : bookdown.theroem.preamble

We need to set that to FALSE for some formats where there is a conflict and document

cc @nuest

nuest commented 3 years ago

Thanks for the ping @cderv. So, I'm trying to remember what was the problem here :-)

With bookdown.theorem.preamble set to FALSE, can we switch back to the syntax that was reverted in https://github.com/rstudio/rticles/pull/288/commits/75ea637d0d8be5bdfefb064190faad31437e61f6 ?

cderv commented 3 years ago

Yes exactly (or almost if we look at the syntax)

If we set this option to false, this should avoid the conflict of two definition of the environment. This means the syntax supported by bookdown could be used with bookdown::pdf_book 

::: {.theorem #testenv-theorem}
Fusce eu leo nisi. Cras eget orci neque, eleifend dapibus felis. Duis et leo dui. Nam vulputate,   velit et laoreet porttitor, quam arcu facilisis dui, sed malesuada risus massa sit amet neque.
:::

I did not try yet with LIPIC format though

cderv commented 3 years ago

@nuest I added the option in the skeleton to show it can be used to deactivate the environment conflict.

nuest commented 3 years ago

Nice!

That means we could switch to the new syntax for theorems, right?

cderv commented 3 years ago

Yes you should be able to. Tell me if it is not working for some reason

github-actions[bot] commented 2 years ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.