rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.46k stars 516 forks source link

bioinformatics: use subject_section in header #415

Closed stephenturner closed 3 years ago

stephenturner commented 3 years ago

fixes #414

To contribute a new article template to this package, please make sure you have done the following things (note that journalname_article below is only an example name):

Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base: https://yihui.name/en/2018/02/bite-sized-pull-requests/

Thank you!

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

cderv commented 3 years ago

Thanks for the contribution !

Should it really be set as the same value as subtitle ?

We could also introduce a new variable to set in YAML like category or manuscript_category and set it to subject_section if not set maybe.

I don't know this journal but we could try do what is more flexible maybe ?

What do you think ?

stephenturner commented 3 years ago

You're right - these are separate things. Looking at a recent application note:

The header shows Application note as the category, with Genome Analysis as the subject

image

stephenturner commented 3 years ago

So, yes, does seem like these should be two separate variables!

cderv commented 3 years ago

You can adapt this PR then and it will be ready to merge! You can add a NEWS bullet also with the new variable. Please add it also in the skeleton Rmd to see how it should be set.

Thanks !

cderv commented 3 years ago

Also, I think the category that should be used are the one in Type of Manuscript in https://academic.oup.com/bioinformatics/pages/instructions_for_authors

right ?

Maybe we should document this too.

stephenturner commented 3 years ago

I think this is fixed and documented in comments in 453e5eb

image

stephenturner commented 3 years ago

NEWS updated in ce82131