rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.46k stars 516 forks source link

Bioinformatics template publication year is hard-coded to 2016 #424

Closed stephenturner closed 2 years ago

stephenturner commented 2 years ago

See here: https://github.com/rstudio/rticles/blob/1d26f7d2268cdeada165b54d6b9cdc0a1e3f8c65/inst/rmarkdown/templates/bioinformatics/resources/template.tex#L2


By filing an issue to this repo, I promise that

I understand that my issue may be closed if I don't fulfill my promises.

cderv commented 2 years ago

Good catch !

I guess this is something that should be set as variable in YAML to be configured by the user in the Rmd file ?

How do you see things for it ?

Would you like to submit a PR to propose a change ?

pinging @ShixiangWang who added the template in #297

cderv commented 2 years ago

@ShixiangWang About this, do you know if this is something that should be changed by the user directly ?

I see the value is in the template available here: https://academic.oup.com/bioinformatics/pages/submission_online

Should we offer a switch to change that from the Rmd file ? Or is it something changed after in the tex file directly ?

Thank you for your help with this.

ShixiangWang commented 2 years ago

@cderv My opinion is removing the \pubyear block directly, so it would not be limited. What about similar cases in other journal templates?

cderv commented 2 years ago

The command is defined in other CLS class from other journals, and we have some other templates that hardcode in the tex template. See https://github.com/rstudio/rticles/search?p=1&q=pubyear

With have one template that defined the pub year as a variable: https://github.com/rstudio/rticles/blob/4aa0a44e4f41b02cfb1d5c1cdc80043b5f42e502/inst/rmarkdown/templates/biometrics/resources/template.tex#L95

We could probably add this as a variable, or indicate in the tex file this should be modified by hand during editing process.

ShixiangWang commented 2 years ago

@cderv That's a great idea. I think it would be a good reference for adding a new journal template.

cderv commented 2 years ago

I have added the variables to change the value in the template

ShixiangWang commented 2 years ago

@cderv Great, thanks for your efforts!

github-actions[bot] commented 2 years ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.