rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.46k stars 516 forks source link

oup_article() support for old and new template #431

Closed dmkaplan2000 closed 2 years ago

dmkaplan2000 commented 2 years ago

Update to OUP format including both old and new templates, with a parameter in the formatting function controlling switching between the two.

It is generally working, but the testing part of the package will not work because it currently assumes that 1 format = 1 directory with the same name, which is not the case for this format. I will leave it to you to correct this.


To contribute a new article template to this package, please make sure you have done the following things (note that journalname_article below is only an example name):

Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base: https://yihui.name/en/2018/02/bite-sized-pull-requests/

Thank you!

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: cderv
:white_check_mark: yihui
:x: David M. Kaplan


David M. Kaplan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

dmkaplan2000 commented 2 years ago

Thanks for this. I will look at the new version down the road, but I am a bit busy right now, so it won't be right away.