cderv
commented
2 years ago Hi @MalteHueckstaedt !
I am fine with the change because you know more about me on this.
However, this included template is based on the files found on the sage pub website https://uk.sagepub.com/en-gb/eur/manuscript-submission-guidelines#LATEX There is a zip you can download there: https://uk.sagepub.com/sites/default/files/sage_latex_template_4.zip
In this zip folder, you will find a SageH.bst which is what we copied for our template. This contains
FUNCTION {bbl.editors}
{ "eds." }
FUNCTION {bbl.editor}
{ "ed." }So should we made a change like this only in our version ? If there is an issue with the SageH.bst file, it would be better to ask them to update there template.
Otherwise, even if we make the correction here, next time we will update it will be lost.
Have you already reached out to Sage about this ?
maltehueckstaedt
CLAassistant
adjustment to the conventions of the editor specifications to Sage-Havard.
See: https://www.sagepub.com/sites/default/files/sage_harvard_reference_style_0.pdf
How to contribute a new output format ?
To contribute a new article template to this package, please make sure you have done the following things (note that
journalname_articlebelow is only an example name):[ ] This project uses a Contributor Licence Agreement (CLA) that you'll be asked to sign when opening a PR. This is required for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). We use a tool called CLA assistant for that.
You could also, unless you have done it in any other RStudio's projects before, sign the individual or corporate contributor agreement. You can send the signed copy to jj@rstudio.com.
[ ] Add the
journalname_article()function toR/article.Rif the output format is simple enough, otherwise create a separateR/journalname_article.R.[ ] Document your function using roxygen2. Markdown syntax is supported. Refer to https://roxygen2.r-lib.org/articles/rd-formatting.html for formatting references.
[ ] Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname/resources/template.tex.[ ] Add a skeleton article
inst/rmarkdown/templates/journalname/skeleton/skeleton.Rmd.[ ] Add a description of the template
inst/rmarkdown/templates/journalname/template.yaml.[ ] Please include the document class file (
*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN. If you are using TinyTeX or TeX Live, you can verify if a package is available on CTAN viatinytex::parse_packages(files = "FILENAME"")(e.g., whenFILENAMEisplain.bst, it should return"bibtex", which means this file is from a standard CTAN package). Please keep the number of new files absolutely minimal (e.g., do not include PDF output files), and also make examples minimal (e.g., if you need a.bibexample, try to only leave one or two bibliography entries in it, and don't include too many items in it without using all of them).[ ] Update Rd and namespace (could be done by
devtools::document()).[ ] Update NEWS.
[ ] Update README with a link to the newly supported journal. Please add your Github username and the full name of the journal (follow other examples in the list).
[ ] Add a test to
tests/testit/test-formats.Rby adding a linetest_format("journalname"). We try to keep them in alphabetical order.[ ] Add your name to the list of authors
Authors@Rin DESCRIPTION. You don't need to bump the package version in DESCRIPTION.Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base: https://yihui.name/en/2018/02/bite-sized-pull-requests/
Thank you!