rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.46k stars 516 forks source link

Update to elsevier template #467

Closed robjhyndman closed 2 years ago

robjhyndman commented 2 years ago

How to contribute a new output format ?

To contribute a new article template to this package, please make sure you have done the following things (note that journalname_article below is only an example name):

Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base: https://yihui.name/en/2018/02/bite-sized-pull-requests/

Thank you!

robjhyndman commented 2 years ago

As per https://github.com/rstudio/rticles/issues/396

cboettig commented 2 years ago

@cderv I don't have any deep insights here (been too long since I was up-to-date on changes to pandoc etc), but perhaps it is worth introducing a version number to the template rather than creating a breaking change? elsevier_article2?

Personally I don't have too many reservations though about requiring the newer version of pandoc going forward without that (particularly if RStudio is shipping with a recent enough version of pandoc). I have plenty of old papers/drafts using the old template, but those usually need to run in version-locked environments anyway as changes to packages or even LaTeX style files can break those builds.

cderv commented 2 years ago

Thanks for the feedback.

perhaps it is worth introducing a version number to the template rather than creating a breaking change? elsevier_article2?

That is one option. We did that for oup_article() by introducing the version scheme as an argument. Not straightforward.

I have plenty of old papers/drafts using the old template, but those usually need to run in version-locked environments anyway as changes to packages or even LaTeX style files can break those builds.

I like this - Maybe I should add a vignette or other documentation to recommend using renv with rticles project so that one can rerun an article with a fixed rticles version. This would allow us to be less conservative about changes in the template.

Considering this, I would go with the breaking change here.

cderv commented 2 years ago

Thanks @robjhyndman !