search

rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.46k stars 516 forks source link

Updates springer article #494

Closed eliocamp closed 1 year ago

eliocamp commented 2 years ago

Closes #491

cderv commented 1 year ago

@eliocamp are you planning to come back to this ?

If not, I'll try to update myself. Just need to know as it's been some time now.

eliocamp commented 1 year ago

Thanks for the reminder! I'll get to it this week. Sorry!

eliocamp commented 1 year ago

Well, hell. They updated the template last month :zany_face: . Now I updated it to the current version. And added a lot of your suggestions.

The documentation of the function should probably be updated

Do you mean the function documentation for springer_article()? What should I add?

Are the .bst file used somewhere ? The line in the TeX template for using it are removed I think

The bst files are needed for the class options (e.g. classoption sn-nature requires sn-nature.bst). They come with the template you download from the publisher.

Some Pandoc's requirement in TeX template are missing and some Pandoc's feature won't probably work (like table, highlighting, etc...) I think we should add them.

Which requirements are missing?

cderv commented 1 year ago

@eliocamp do you have time to look at it today ? I would like to do a release for tomorrow or Monday at last. It would be good to have this new formats ! Sorry for pushing on this. If you can't, I'll handle myself and make the choices.

eliocamp commented 1 year ago

I can work on it tomorrow.

eliocamp commented 1 year ago

I think that's all.

cderv commented 1 year ago

@eliocamp did you check the theorem style environment are working ?

I get this warning

Warning: Package amsthm Warning: Unknown theoremstyle `thmstyleone' on input line 49.
Warning: Package amsthm Warning: Unknown theoremstyle `thmstyletwo' on input line 56.
Warning: Package amsthm Warning: Unknown theoremstyle `thmstylethree' on input line 60.

and it seems the default styles defined in the sn-jnl.cls is not working. Did you notice that too ?

eliocamp commented 1 year ago

Yeah, I got those too but I don't understand what the warning is about. Thet come up even with the unmodified template.

cderv commented 1 year ago

OK it seems the class file is broken on this then. Maybe not the right way to create style environment.

I'll move the theorem part as header include then to make it optional and customizable and not hard code those definitions. thanks !