rstudio / rticles

LaTeX Journal Article Templates for R Markdown
https://pkgs.rstudio.com/rticles/
1.47k stars 519 forks source link

Make orcidlink.sty inclusion in JSS template conditional #512

Closed Enchufa2 closed 1 year ago

Enchufa2 commented 1 year ago

Please allow me to revisit this issue (#493, #495), because since the introduction of the ORCiD feature in #465, we have been experiencing warnings on CRAN for macOS machines. See e.g. this. So far I haven't received any ultimatum from CRAN, but I suspect that this would bite at some point. So I would like to propose to make the inclusion of ORCiD links conditional to the presence of this package (e.g. via \IfFileExists{}{}).


By filing an issue to this repo, I promise that

I understand that my issue may be closed if I don't fulfill my promises.

cderv commented 1 year ago

I am ok to make this package optional, but to clarify, we are using the JSS template as base (the one from https://www.jstatsoft.org/style) which includes orcidlink usage. Making it conditional in our template, means there will be one more manual step when we update. I would suggest you do a PR and if this is simple enough conditional then I'll consider merging. Basically, what would make sense considering Pandoc's template would be to only load the package when orcid is used as an author field (this is when \orcidlink{} command is needed and the package needs to be loaded)

For this one change I guess it is possible, but there could be other issues later on as in your case the real issue is that CRAN servers do not have all the LaTeX requirement available to build JSS tex template. Hopefully, orcidlink in the only issue.

Enchufa2 commented 1 year ago

I see. Let me ask on CRAN then whether they are willing to add this file to those machines.

cderv commented 1 year ago

Great - good idea ! Thanks for willing to do that.

I really don't know how they handle (or want to handle) TeX dependencies from CTAN. the sty file needed here is from CTAN package https://ctan.org/pkg/orcidlink that they would need to make available

Enchufa2 commented 1 year ago

From Simon Urbanek:

Ok, I have bumped TL to 2022 on arm64 and just installed orcidlink it by hand on x86_64 since we don't have enough disk space to do both there, so hopefully next builds should not issue that warning.

So we can close this.

cderv commented 1 year ago

Awesome ! thanks for the update on this !

github-actions[bot] commented 1 year ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.