Open vboyce opened 1 year ago
Thanks for helping figure out what to do here -- I really appreciate it!
I edited the glossa.cls myself (for context, I was submitting to glossa psycholingustics, used the glossa template because it was the closest thing available on rticles, but then had to make changes at the copyediting stage and messing with the .cls was the hack I used to get the formatting to meet their rules). I understand that's not good from a transparency / maintenance standpoint.
I think I could put the latex differences in the template instead (where they would overrule the .cls). For that matter, I think it could go in a header-includes: part of the yaml in the skeleton.Rmd, and then use the same template file as glossa?
I don't know of a glossapsycholinguistics latex template (it's a new journal), but I could ask the EiCs if a template or class file exists.
I think I could put the latex differences in the template instead (where they would overrule the .cls).
That would be better yes !
For that matter, I think it could go in a header-includes
Yes if the place of insertion for header-includes
is fine, then this will be a good solution. Otherwise, we can tweak the glossa_article()
R function and its template to add in the right place. (by adding a journal
argument in the function for example, and acting on it when set to glossapx
to pass new content as variables to the template)
I don't know of a glossapsycholinguistics latex template (it's a new journal), but I could ask the EiCs if a template or class file exists.
This would be really good to know, to confirm that adapting from glossa.cls
is the right thing to do.
part of the yaml in the skeleton.Rmd, and then use the same template file as glossa?
If we can use the glossa_article()
function, with few tweaks, it is the easiest for the package. Then we need to decide if we do a common skeleton.Rmd with some information to adapt, or I could also see if we can provide two skeleton Rmd and one would choose the desired one. Could be easier right ?
I got in contact with the editors of Glossa Psycholinguistics, and they are in the process of making a latex template for the journal. So, I'm going to wait for there to be the journal provided template and then build the rticles skeleton/template to go with it.
Ok let's do this then. Do they provide an ETA for such template ?
I'll move this PR as draft to track that we are waiting for more. Thanks again !
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
How to contribute a new output format ?
To contribute a new article template to this package, please make sure you have done the following things (note that
journalname_article
below is only an example name):[x] This project uses a Contributor Licence Agreement (CLA) that you'll be asked to sign when opening a PR. This is required for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). We use a tool called CLA assistant for that.
You could also, unless you have done it in any other RStudio's projects before, sign the individual or corporate contributor agreement. You can send the signed copy to contribute@rstudio.com.
[x] Add the
journalname_article()
function toR/article.R
if the output format is simple enough, otherwise create a separateR/journalname_article.R
.[x] Document your function using roxygen2. Markdown syntax is supported. Refer to https://roxygen2.r-lib.org/articles/rd-formatting.html for formatting references.
[x] Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname/resources/template.tex
.[x] Add a skeleton article
inst/rmarkdown/templates/journalname/skeleton/skeleton.Rmd
.[x] Add a description of the template
inst/rmarkdown/templates/journalname/template.yaml
.[x] Please include the document class file (
*.cls
) if needed, but please do not include standard LaTeX packages (*.sty
) that can be downloaded from CTAN. If you are using TinyTeX or TeX Live, you can verify if a package is available on CTAN viatinytex::parse_packages(files = "FILENAME"")
(e.g., whenFILENAME
isplain.bst
, it should return"bibtex"
, which means this file is from a standard CTAN package). Please keep the number of new files absolutely minimal (e.g., do not include PDF output files), and also make examples minimal (e.g., if you need a.bib
example, try to only leave one or two bibliography entries in it, and don't include too many items in it without using all of them).[x] Update Rd and namespace (could be done by
devtools::document()
).[x] Update NEWS.
[x] Update README with a link to the newly supported journal. Please add your Github username and the full name of the journal (follow other examples in the list).
[x] Add a test to
tests/testit/test-formats.R
by adding a linetest_format("journalname")
. We try to keep them in alphabetical order.[x] Add your name to the list of authors
Authors@R
in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.Lastly, please try your best to do only one thing per pull request (e.g., if you want to add two output formats, do them in two separate pull requests), and refrain from making cosmetic changes in the code base: https://yihui.name/en/2018/02/bite-sized-pull-requests/
Thank you!
I'm new to contributing to packages, so please forgive any mistakes and let me know if there are things I need to fix! I followed the checklist, but wasn't sure how to link to the PR in the NEWS or README since I didn't know what number it would have.