search

rstudio / sass

Sass compiler package for R
https://rstudio.github.io/sass/
Other
102 stars 17 forks source link

Various speed improvements #98

Closed cpsievert closed 2 years ago

cpsievert commented 2 years ago

Various speed improvements inspired by investigation into https://github.com/rstudio/bslib/issues/369

  1. Avoid validation of sass_layer() input when joining two layers together
  2. Avoid writing attachments on a sass() cache hit if output hasn't changed
  3. Use a faster way to get package installation/versions via {staticimports}
  4. Avoid other miscellaneous duplicate work in sass()
cpsievert commented 2 years ago

@wch just FYI, the CI failures are also happening on the main branch -- I'll address those in a separate PR

wch commented 2 years ago

I think the functions need to be re-imported -- the versions in https://github.com/wch/staticimports/pull/11 aren't exactly the same as what's in this PR.

cpsievert commented 2 years ago

Failure to install on Windows 3.6 seem to be an Rtools issue that should be addressed in {shiny-workflows}, so merging