search

rstudio / shiny-examples

Other
1.96k stars 3.78k forks source link

A test app for updating input widget labels #140

Closed cpsievert closed 5 years ago

cpsievert commented 5 years ago

For testing https://github.com/rstudio/shiny/pull/2406.

Definitely open to suggestions for making it easier for testers to understand what constitutes a test pass.

wch commented 5 years ago

We'll want to confirm that rstudio/shiny#2406 actually works with regular selectInputs, where selectize=FALSE.

cpsievert commented 5 years ago

It does, thanks for catching that!

cpsievert commented 5 years ago

Use col-xs-6 instead of col-sm-6.

cpsievert commented 5 years ago

Every time

wch commented 5 years ago

One other little thing: the labels display as An <i>escaped</i> Label -- it would be good to mention in the instructions that this is expected.

cpsievert commented 5 years ago

@wch good to merge?