Add a test for `setInputValue(..., {priority: "event"})`

rstudio / shiny-examples

Other

1.97k stars 3.77k forks source link

Add a test for `setInputValue(..., {priority: "event"})` #162

Closed jcheng5 closed 5 years ago

cpsievert commented 5 years ago

Looks good. Although, this passes even without https://github.com/rstudio/shiny/pull/2619, is it not worth designing a test that fails without it?

jcheng5 commented 5 years ago

@cpsievert The test that fails without it is the submitbutton app. I added this test because setInputValue was only working by accident (it was accidentally reading window.name, which was only working because a previous decorator was consistently accidentally writing to window.name!).