rstudio / shiny-server

Host Shiny applications over the web.
https://rstudio.com/shiny/server
Other
712 stars 290 forks source link

ui.Rmd support #466

Open jcheng5 opened 3 years ago

jcheng5 commented 3 years ago

(Maybe this already works?) https://github.com/rstudio/rmarkdown/pull/1926

aronatkins commented 3 years ago

The logic here will need adjusting: https://github.com/rstudio/shiny-server/blob/191c32ca9be500755862ad1b1e8dbade9b63b0bc/lib/router/router.js#L229-L257

Having server.R no longer indicates a Shiny application by itself. Here is how we perform the detection in rsconnect: https://github.com/rstudio/rsconnect/pull/461

The R/SockJSAdapter.R uses rmarkdown::run if SHINY_MODE is rmd. That is enough (with new rmarkdown install).

jcheng5 commented 3 years ago

Thanks @aronatkins!