Give sed POSIX-compliant input to remove the need for gsed. Add FreeBSD support.

rstudio / shiny-server

Host Shiny applications over the web.

https://rstudio.com/shiny/server

Other

719 stars 289 forks source link

Give sed POSIX-compliant input to remove the need for gsed. Add FreeBSD support. #546

Open mtbakerguy opened 1 year ago

mtbakerguy commented 1 year ago

This is the first of two patches that make it easier to run shiny-server on FreeBSD.

mtbakerguy commented 1 year ago

/^.*"version": .*$/!d;s/",//;s/^.*"//

Delete every line w/o the version in it; drop the trailing ", and all the characters through the final double quote.

mtbakerguy commented 1 year ago

The second patch could be simpler but FreeBSD's deprecated procfs: https://man.freebsd.org/cgi/man.cgi?query=procfs&sektion=5

mtbakerguy commented 1 year ago

Forgot to mention the delete[] newargs; change was a fixup for a minor issue the clang compiler found.

goshkis commented 1 year ago

Nice. +1 to have it in.

noamross commented 7 months ago

@mtbakerguy I've been looking for a way to install Shiny Server on FreeBSD, based on your posts here and on the Posit forum it seems you have it figured it out. Besides making the changes in this PR, have you written down anywhere the steps taken to do so? I'd be most grateful! 🙏