Open schloerke opened 1 year ago
This issue proposes shiny
as the directoy
- Use
"shiny"
as subfolder withininst
to distinguish from generically named "examples" folder
In #3917, Karan used shiny-examples
https://github.com/rstudio/shiny/blob/e0d67873830e09465f05925970abc81fb129ca90/R/run-example.R#L80
and I generally agree with him -- but I think we should name this folder examples-shiny
.
I think shiny
is too generic and there are lots of reasons someone might want to include a bare shiny
folder in their package. But examples-shiny
sorts with the original examples folder and makes its purpose very clear.
I think this can be closed now?
I think this can be closed now?
I thought there was still some planned work around user conveniences. My implementation was kind of bare-bones compared to what Karan had started.
Prior PR https://github.com/rstudio/shiny/pull/1458 that sparked conversation. (Note: PR closed when HEAD branch was moved.)
Goal
Adopt some
plumber::plumb_api()
functionality forshiny::runExample()
:edit
parameter."shiny"
as subfolder withininst
to distinguish from generically named "examples" folderexamples
as is. Packages like{shinytest2}
depend on it being there.inst/shiny
appsCode to alter from:
{plumber}
PR: https://github.com/rstudio/plumber/pull/631{plumber}
function implementation: https://github.com/rstudio/plumber/blob/e829af6a94380cb897441c1c56129504afb9564f/R/plumb.R#L84-L290