search

rstudio / shiny

Easy interactive web applications with R
https://shiny.posit.co/
Other
5.35k stars 1.87k forks source link

Invisible character in img() or a()? #922

Open mbacou opened 9 years ago

mbacou commented 9 years ago

Hi, I just noticed a small problem in the following simple UI code:

    column(6, style="text-align:right;",
      p(
        a(href="http://ifpri.org/", img(src="../assets/R_ifpri.png"),
          title="International Food Policy Research Institute"),
        a(href="http://www.pim.cgiar.org/", img(src="../assets/R_pim.png"),
          title="CGIAR Research Program on Policies Institutions and Markets"),
        a(href="http://umn.edu/", img(src="../assets/R_umn.png"),
          title="University of Minnesota"))
    )

This shows small - characters between each image, that I am not able to identify.

image

Maybe someone knows. Thx, --Mel.

jcheng5 commented 9 years ago

Shoot, this looks like white space being introduced between the inside of the a tag and the outside of the img tag. This happens because of the indentation style we use for the generated HTML--it is a problem we will need to correct in htmltools.

Until then the unfortunate workaround is to use HTML("<a href="...

Sorry for the inconvenience. On Sat, Aug 8, 2015 at 5:26 AM Melanie Bacou notifications@github.com wrote:

Hi, I just noticed a small problem in the following simple UI code:

column(6, style="text-align:right;",
  p(
    a(href="http://ifpri.org/", img(src="../assets/R_ifpri.png"),
      title="International Food Policy Research Institute"),
    a(href="http://www.pim.cgiar.org/", img(src="../assets/R_pim.png"),
      title="CGIAR Research Program on Policies Institutions and Markets"),
    a(href="http://umn.edu/", img(src="../assets/R_umn.png"),
      title="University of Minnesota"))
)

This shows small - characters between each image, that I am not able to identify.

[image: image] https://cloud.githubusercontent.com/assets/260325/9150448/f5f1c8c0-3da6-11e5-82b7-36727c31eac9.png

Maybe someone knows. Thx, --Mel.

— Reply to this email directly or view it on GitHub https://github.com/rstudio/shiny/issues/922.

mbacou commented 9 years ago

OK thx very much for checking. Will do for now.

wch commented 9 years ago

It might be time to bite the bullet and fix rstudio/htmltools#19.

jonthegeek commented 1 year ago

It looks like this was fixed when https://github.com/rstudio/htmltools/issues/19 was closed.