search

rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

Adding shinyjster tests for updateDateRangePicker functionality #125

Closed MadhulikaTanuboddi closed 3 years ago

MadhulikaTanuboddi commented 3 years ago

Connected to https://github.com/rstudio/shinycoreci-apps/issues/124

shinyjster test covers the following cases

  1. For every slider value change (currently from 6 - 25), we are verifying a. From date is (slider value - 1). b To date is (slider value + 1) c. Possible selectable dates in both from and to date pickers are (slider value - 5) and (slider value + 5). For ex: for a slider value "7", this would be [2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]

  2. Currently using hard coded month/year in the date picker. In the future, will work on using dynamic dates

wch commented 3 years ago

Looks good overall! I suggest we test fewer dates, though -- testing every single value from slider_min to slider_max doesn't really add anything compared to testing, say, 3 or 4 dates, but it does cause the tests to take more time.