search

rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

GHA: 205-dynamic-tabs-compat: Test failing with cosmo4 theme #126

Closed MadhulikaTanuboddi closed 3 years ago

MadhulikaTanuboddi commented 3 years ago

This test started failing since March 17, 2021. Could be due to https://github.com/rstudio/bslib/commit/df10a878e0e9d1e42c83b4c2101bc8d9f00ad314

Failing on all OS and R versions

Tab panel title shown on the right instead of left

OLD snapshot:

205-dynamic-tabs-compat-OLD

NEW snapshot:

205-dynamic-tabs-compat-new

Other png diffs:

205-dynamic-tabs-compat-other-diffs
MadhulikaTanuboddi commented 3 years ago

March 25 test results review:

Previous Tab panel title seems to be fixed.

Now, Test failing at the navlistPanel() controls section. Infact, the comparison of old and new snapshots in this case does not make sense at all. OLD is looking at the second tabPanel with name "0" and NEW is looking at the first tabPanel with name "Base tab"

Check the old and new snapshots.

OLD:

March-25-205-dynamic-tabs-compat-cosmo4-OLD

NEW

March-25-205-dynamic-tabs-compat-cosmo4-new

@cpsievert : can you please double check this?

cpsievert commented 3 years ago

Seems this is a real thing we'll need to fix in Shiny