search

rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

GHA: "054-nvd3-line-chart-output" app's missing slider ticks with window size #156

Closed MadhulikaTanuboddi closed 3 years ago

MadhulikaTanuboddi commented 3 years ago

Run the app https://github.com/rstudio/shinycoreci-apps/blob/master/apps/054-nvd3-line-chart-output/ui.R

  1. runApp("054-nvd3-line-chart-output")
  2. Notice the ticks on the 2 ionrangeslider inputs - (all should be visible if you open the app in a browser with default window size)
  3. Adjust/shrink the window size to <=1000 pixels X 750 pixels. Notice the ticks on the sliderInputs.
  4. At some points, you should see a specific slider tick value is missing in each of the sliderInput.

054nvd3-app-slider-ticks-missing-with-window-size

shinytest test differences show different results based on the OS. for ex: Linux: Both slider values already empty and were accepted as new expected (Not sure when). Mac: why sliders values missing in new snapshots? Win: Slider value missing only in sine amplitude slider input

Anyways, we discussed this with @cpsievert and he suggested this could be due to his recent change on ionrangeslider https://github.com/rstudio/shiny/commit/dc9c6ae7699b54459ead544517dd72fc9ba562d0. We decided at this point this is low priority to be fixed.

From QA: Currently accepted the snapshots with the ticks missing. Probably will adjust the window size for this app to make sure shinytest captures the sliderInputs with all the ticks visible.