rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

Bootstrap 5 testing #159

Open cpsievert opened 3 years ago

cpsievert commented 3 years ago

This PR modifies all relevant testing apps to use Bootstrap 5 (i.e., bslib::bs_theme(version = 5)).

After discussing with @shalutiwari today, we're thinking we won't expand the usual testing matrix to include Bootstrap 5. Instead, once we're close to a releasing, we'll open a PR like this one to get results for a specific version of Bootstrap that we're interested in. For this release, we need to specifically opt-in to using version = 5 (since version = 4 is still the default), but after this release it probably makes sense to maintain a bslib branch that adds bs_theme() instead of bs_theme(version = 5).