rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

Update shinytest based on GHA runs failing on certain builds #170

Closed MadhulikaTanuboddi closed 3 years ago

MadhulikaTanuboddi commented 3 years ago

Previously, when the dismiss button is clicked, on certain builds, the snapshot is taken too quickly such that we are not waiting enough time for modal to be hidden. The builds I noticed failing with this issue are

linux-3.5
linux 3.6
mac 3.5
mac 4.0
win 3.6
win 4.0
win 4.1

So, I am attempting to apply the same logic from https://github.com/rstudio/shinycoreci-apps/blob/master/apps/115-remove-modal/tests/shinytest/mytest.R#L14-L21 to see if it helps.

This is a followup PR from https://github.com/rstudio/shinycoreci-apps/pull/166