search

rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

Linux builds - 016-knitr-pdf shinytest diff viewer takes time to load #184

Closed MadhulikaTanuboddi closed 3 years ago

MadhulikaTanuboddi commented 3 years ago

When running the shinycoreci::fix_all_gha_branches(), I ran in to the following issue with all the linux- R builds with 016-knitr-pdf app

The shinytest diff window wont load for a long time (almost several hours) and during this I could not do any mouse interactions with the IDE/shinytest window.

Sep_17_shinycoreci-apps_fix_branches

Barret mentioned this is due to the .download file differences (esp with Jquery version update) taking a long time to be processed.

@schloerke : Please add more details as you find it relevant. Thank you

schloerke commented 3 years ago

It is trying to display a diff of jquery 1.11 to jquery 3.6; Since both of these are on a single line, the text diff is very large. I believe the diff viewer is being overwhelmed and it is taking a really long time to display.

Worked around it by using shinytest::snapshotUpdate(....). Related: https://github.com/rstudio/shinycoreci/pull/80