search

rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

GHA: `026-shiny-inline` test failures with rendering bold text #199

Closed MadhulikaTanuboddi closed 2 years ago

MadhulikaTanuboddi commented 2 years ago

https://github.com/rstudio/shinycoreci-apps/tree/main/apps/026-shiny-inline app does not render the bolded text correctly since the change with https://github.com/rstudio/htmltools/commit/72cc41ef38c587e34d130045451ea95e0ef851dc.

Shinytest tests were failing due to the same.

026-shiny-inline-htmltools-bold-text
MadhulikaTanuboddi commented 2 years ago

Introduced by https://github.com/rstudio/htmltools/pull/306 and Should be fixed by https://github.com/rstudio/htmltools/pull/308

MadhulikaTanuboddi commented 2 years ago

Verified on 12/21- Not fixed yet. checking with Carson

cpsievert commented 2 years ago

Thanks @MadhulikaTanuboddi, looks like rstudio/htmltools#308 fixed the issue for statically rendered inline code blocks, but looks like Shiny will need a change to fix it for dynamically rendered ones

cpsievert commented 2 years ago

Let's track this issue via https://github.com/rstudio/shiny/issues/3568 instead of here.

(I'll update the Trello card to point to the Shiny issue/PR)