rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

Should push changes if new shinytest results are added, even if none failed #8

Open wch opened 4 years ago

wch commented 4 years ago

When adding new shinytest tests, it's common to not add expected results for all platforms. For example, when I add new tests from my usual development machine, I add expected results for mac, but not Windows. Also, the screenshots from my Windows computer have too-large web widgets, because phantomjs uses the current screen resolution for deciding how big widgets like checkboxes and radio buttons should be, so it makes sense to only get the Windows screenshots from the headless CI machines.

When I push new tests, none of them fail, and so the new results for Windows will not be saved. I think the way to solve this is, at the end, to check for any new "-expected-mac" (or "win"/"linux") directories and throw an error if any are found.