search

rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

Github Actions: 194-plot-cache-key test failing at reactlog #83

Closed MadhulikaTanuboddi closed 3 years ago

MadhulikaTanuboddi commented 3 years ago

Steps:

  1. Run 194-plot-cache-key shiny app using shinytest
  2. The test is failing for past few days due to a new output event being displayed

Old result snapshot:

Old_194-plot-cache-key

New result snapshot:

New-194-plot-cache-key

Ref: https://github.com/rstudio/shinycoreci-apps/runs/1416965207?check_suite_focus=true

MadhulikaTanuboddi commented 3 years ago

@wch: This test is still failing (with a different set of reactlog differences). Here are the old and new snapshots from the shinytest results. Please let me know if you need more details.

OLD:

194-plot-cache-key-old-snapshot

NEW:

194-plot-cache-key-new-snapshot

Barret pointed out that 4 new observers are added in the new snapshot 194-plot-cache-key-observe-events_added

Ref: https://github.com/rstudio/shinycoreci-apps/runs/1485025112?check_suite_focus=true#step:30:11706

wch commented 3 years ago

Thanks, I think we have a fix for it now!

MadhulikaTanuboddi commented 3 years ago

Here is the latest expected dependency graph approved by Winston:

194-plot-cache-key-reactlog-dependency-graph-Dec 4

Helpful notes from Barret:

_The extra observeEventHandler is not added to the reactlog anymore And the observer previously labelled observeEvent({ evaltidy(qs) }) has a better label now

The original bad label was fixed in https://github.com/rstudio/shiny/pull/3160 The extra/white reactives was fixed in https://github.com/rstudio/shiny/pull/3177 The random reactiveVal with value 0 was fixed in https://github.com/rstudio/shiny/pull/3180

MadhulikaTanuboddi commented 3 years ago

Will close this issue once we update the expected snapshots in different branches and make sure when the test passes in GHA

MadhulikaTanuboddi commented 3 years ago

Verified. Ref: https://trello.com/c/pRfzaNmb/521-app-194-plot-cache-key-fix-labels-with-bindevent