Closed MadhulikaTanuboddi closed 3 years ago
@wch: This test is still failing (with a different set of reactlog differences). Here are the old and new snapshots from the shinytest results. Please let me know if you need more details.
OLD:
NEW:
Barret pointed out that 4 new observers are added in the new snapshot
Ref: https://github.com/rstudio/shinycoreci-apps/runs/1485025112?check_suite_focus=true#step:30:11706
Thanks, I think we have a fix for it now!
Here is the latest expected dependency graph approved by Winston:
Helpful notes from Barret:
_The extra observeEventHandler is not added to the reactlog anymore And the observer previously labelled observeEvent({ evaltidy(qs) }) has a better label now
The original bad label was fixed in https://github.com/rstudio/shiny/pull/3160 The extra/white reactives was fixed in https://github.com/rstudio/shiny/pull/3177 The random reactiveVal with value 0 was fixed in https://github.com/rstudio/shiny/pull/3180
Will close this issue once we update the expected snapshots in different branches and make sure when the test passes in GHA
Steps:
194-plot-cache-key
shiny app using shinytestOld result snapshot:
New result snapshot:
Ref: https://github.com/rstudio/shinycoreci-apps/runs/1416965207?check_suite_focus=true