search

rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

Github Actions: 202-flexdashboard-kmeans css changes #90

Closed MadhulikaTanuboddi closed 3 years ago

MadhulikaTanuboddi commented 3 years ago

Ref: https://github.com/rstudio/shinycoreci-apps/runs/1491318073?check_suite_focus=true#step:30:11400

This test has been failing due to some css changes and as result of the left sidebar panel's input widgets being shifted to the top.

Here are Old and New snapshots (and json) of the shinytest results

OLD:

202-flexdashboard-kmeans-old

NEW

202-flexdashboard-kmeans-new

JSON:

202-flexdashboard-kmeans-sample-json-changes

DIFFERENCES

Dec22-202-flexdashboard-kmeans-differences
MadhulikaTanuboddi commented 3 years ago

Carson mentioned this is low priority atm

cpsievert commented 3 years ago

Turns out this difference is a result of this change in rmarkdown: https://github.com/rstudio/rmarkdown/commit/d29ba32b8f3e35b5c25ffc4bc22dac3a2aa915f8

Without that change, a missing paragraph (<p></p>) used to be present at the top of the sidebar. After this change, the missing paragraph goes away. If we end up doing anything here, it probably makes most sense to add some padding-top to flexdashboard's .sidebar CSS