search

rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

Github Actions: 037-date-and-date-range input test failures #91

Closed MadhulikaTanuboddi closed 3 years ago

MadhulikaTanuboddi commented 3 years ago

Connected to https://github.com/rstudio/shiny/pull/3188

App: 037-date-and-date-range: Ref: https://github.com/rstudio/shinycoreci-apps/runs/1522660796?check_suite_focus=true#step:30:11965

Shinytest results

JSON Differences

037-date-and-date-range_Dec_8_JSON

Old:

037-date-and-date-range-old-Dec-8

New:

037-date-and-date-range-New-Dec-8
MadhulikaTanuboddi commented 3 years ago

I tested/reviewed this app locally. It seems like for "Date input 2" and "Date range input 2" inputs, I could not select a date in the Month of January 2020 anymore. Hence both those checks are failing.

Date_input2_testing_January_month_disabled

I am still trying to understand why certain months and dates are not selectable anymore (in both of the above inputs especially when using other languages -> ja and fr in this case. Any explanation and context will be helpful. cc: @wch

MadhulikaTanuboddi commented 3 years ago

@wch: Fyi, https://github.com/rstudio/shinycoreci-apps/blob/master/apps/170-date-range-max/app.R shinyjster tests also started failing since Tuesday -> https://github.com/rstudio/shinycoreci-apps/runs/1516050899?check_suite_focus=true#step:30:11851

Looks related to above. Please let me know if not (I will add this as a separate issue)

170-daterange-max-shinyjster_test_failing
MadhulikaTanuboddi commented 3 years ago

Verified with manual testing (Ref: https://trello.com/c/zE9Q7gP2/2168-dateinput-fixes) GHA does not show this test failing anymore. Also 209-date-picker shinyjster test added - https://github.com/rstudio/shinycoreci-apps/tree/master/apps/209-datepicker