search

rstudio / shinycoreci-apps

SUPERSEDED - Apps for Shiny continuous integration testing
Other
36 stars 4 forks source link

Add shinyvalidate test #92

Open nstrayer opened 3 years ago

nstrayer commented 3 years ago

This app tests primarily shinyvalidate but also uses bslib to repeat the same test with three different bootswatch styles.

Currently, the app only tests a subset of the bootswatches (this could be programmatically made to do all but may be computationally too expensive/unnecessary.

Screenshot of app on load:

image

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

nstrayer commented 3 years ago

Updated to the much simpler method of switching the theme suggested by Carson.

I also tried to add bootstrap version switching to test but we realized that it's not actually possible to switch bootstrap versions within a running app due to just updating style sheets and not JS. See https://github.com/rstudio/shiny/issues/3202 for more details.

nstrayer commented 3 years ago

Forgot to mention that this test requires this PR to shinyvalidate to properly render the feedback messages.

cpsievert commented 3 years ago

Will also need https://github.com/rstudio/shinyvalidate/pull/47