Upgrade AdminLTE to 2.4.8

rstudio / shinydashboard

Shiny Dashboarding framework

https://rstudio.github.io/shinydashboard/

Other

887 stars 299 forks source link

Upgrade AdminLTE to 2.4.8 #298

Open alandipert opened 5 years ago

alandipert commented 5 years ago

I upgraded to 2.4.8 to see if it would magically fix #297, but it didn't.

I figured I'd push the upgrade work here anyway so we can look at it later. Some changes to our build scripts were necessary because of changes in AdminLTE.

wch commented 5 years ago

Be sure to take a look at https://github.com/rstudio/shinydashboard/blob/2522242f/srcjs/AdminLTE/README-shiny-mods.md.

I'm not really sure why there's a copy of app.js in that directory. Now that I think of it, that README should probably be moved to the tools/ directory, and the tools/README should have better information about how to upgrade AdminLTE. For example, see https://github.com/rstudio/httpuv/blob/9a7f0983f/src/README.md

All that said, we don't have to do this update right now - we can hold it for later.

mbacou commented 5 years ago

What's the status on an AdminLTE 2.4.8 upgrade? Seems the branch is not ready for merging yet? Looking forward to having new layout options, right sidebar, top header navigation, and themes. Thx.

alandipert commented 5 years ago

Thanks for your interest; I think we still just need to work on our tooling a little bit before calling it done. I'll post updates here.

Rhydderch commented 4 years ago

Hi, any updates regarding the update of shiny dashboard to the latest version of AdminLTE ? Or would there be a wayfor us to do it ourselves ? (The latest version looks gorgeous ! https://adminlte.io/themes/dev/AdminLTE/index2.html )

mbacou commented 4 years ago

@Rhydderch FYI documentation is a bit scant, but a combination of bs4Dash and fresh (for customizing the bs4 and AdminLTE3 themes) has worked for me.

It's a bit rough around the edges, some Shiny widgets (dateInput, selectInput) have not been updated to BS4 yet, and hence might not respect all theme customization, but it works.

Rhydderch commented 4 years ago

@Rhydderch FYI documentation is a bit scant, but a combination of bs4Dash and fresh (for customizing the bs4 and AdminLTE3 themes) has worked for me.

It's a bit rough around the edges, some Shiny widgets (dateInput, selectInput) have not been updated to BS4 yet, and hence might not respect all theme customization, but it works.

@mbacou Thank you so much. I will look into it but it seems good enough. And I can see bs4Dash is still actively maintained and updated, which is nice. Even if it's a bit rough around the edges, I guess it will already be a nice visual upgrade from shiny dashboard!

CLAassistant commented 8 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}