search

rstudio / shinydashboard

Shiny Dashboarding framework
https://rstudio.github.io/shinydashboard/
Other
893 stars 298 forks source link

Add necessary CSS selectors for new FontAwesome #301

Closed AshesITR closed 4 years ago

AshesITR commented 5 years ago

New FontAwesome icons aren't guaranteed to have class fa anymore. Brands have fab, solid (normal) icons can have fas, regular icons (some are free, most are FontAwesome Pro only) have class far and light icons (FontAwesome Pro only) have fal as "primary" class.

See https://github.com/rstudio/shiny/issues/2260

jcheng5 commented 5 years ago

Thanks for this patch! If you haven't contributed a patch to an RStudio repository before, can I get you to sign an individual or corporate contributor agreement? You can send the signed copy to jj@rstudio.com.

xhdong-umd commented 5 years ago

@AshesITR Any update on this PR?

AshesITR commented 5 years ago

@jcheng5 The PR should be good to merge?

AshesITR commented 4 years ago

bump?

dracodoc commented 4 years ago

Checking again and found this is still not merged. I just made a temporary workaround in case there is other people needing this before the PR is merged.

Below will force the icon to be v4.7 and there will not be a problem.

  icon_g <- icon("github")
  icon_g[["attribs"]][["class"]] <- "fa fa-github"
jcheng5 commented 4 years ago

Gosh, sorry everyone who was waiting for this!