rstudio / shinydashboard

Shiny Dashboarding framework
https://rstudio.github.io/shinydashboard/
Other
893 stars 298 forks source link

add "hidden-xs" class to logo … #310

Open DivadNojnarg opened 5 years ago

DivadNojnarg commented 5 years ago

Consider the following example with the current version of shinydashboard, on a cellphone for instance:

library(shiny)
library(shinydashboard)
shinyApp(
  ui = dashboardPage(
    dashboardHeader(),
    dashboardSidebar(),
    dashboardBody(),
    title = "Dashboard example"
  ),
  server = function(input, output) { }
)

capture d ecran 2019-02-12 a 08 56 05

We have a blue bar above the sidebar trigger taking unnecessary vertical space.

This simple PR aims at adding the extra class "hidden-xs" to "logo", so that it is not displayed on small screen devices when the title is NULL in dashboardheader (even though it is better to give a title):

span(class = if (is.null(title)) "logo hidden-xs" else "logo", title)
DivadNojnarg commented 5 years ago

On the AppVeyor build, I see installation of package 'later' had non-zero exit status

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.