update documentation Glyphicons link

rstudio / shinydashboard

Shiny Dashboarding framework

https://rstudio.github.io/shinydashboard/

Other

885 stars 300 forks source link

Closed bhogan-mitre closed 3 years ago

bhogan-mitre commented 3 years ago

The documentation shows a Glyphicons link as http://getbootstrap.com/components/#glyphicons I believe this should be update to: https://icons.getbootstrap.com/

I'm happy to submit a PR if you're open to it and point me to where the documentation lives. Thanks.

wch commented 3 years ago

shinydashboard uses Bootstrap 3, so I think the correct link is: https://getbootstrap.com/docs/3.4/components/#glyphicons

I believe that https://icons.getbootstrap.com/ is a separate project?

bhogan-mitre commented 3 years ago

Ah, thank you. I know I've seen that page before, it was just harder to find from the link in the shinydashboard documentation.

wch commented 3 years ago

Fixed in 1c2dc5b. Thanks!