rstudio / shinydashboard

Shiny Dashboarding framework
https://rstudio.github.io/shinydashboard/
Other
896 stars 298 forks source link

SidebarMenu menuItem href elements contain the aria-selected tag #385

Open emichaud998 opened 2 years ago

emichaud998 commented 2 years ago

I have an R shiny dashboard and I am currently trying to fix accessibility issues flagged by the axe DevTools chrome extension, and I have been able to fix all the issues but one. The issue that I cannot resolve is flagged by a test that ensures ARIA attributes are allowed for an element's role. The problem is that the sidebarMenu's menuItems contain href elements that contain the aria-selected tag which is automatically set to true when the tab is selected or set to false when a different tab is selected. However, these elements should not have this type of tag, which is why it is failing the accessibility check. I have tried removing the tags and replacing it with aria-current manually using JS every time a menuItem is selected, since aria-current is allowed, but the aria-selected tag is added back automatically by the sidebarMenu code, so I am not able to remove it and fix the issue.

YongbingDing commented 2 years ago

您好,丁永兵已经收到您的邮件,谢谢。