search

rstudio / shinydashboard

Shiny Dashboarding framework
https://rstudio.github.io/shinydashboard/
Other
896 stars 298 forks source link

align shinydashboard tab data-value with shiny tabs #390

Open carlganz opened 2 years ago

carlganz commented 2 years ago

I guess you'd probably want to update the codebase to use bslib, but since that is a lot of work updating shiny dashboard tabs to include a data-value will allow other shiny related packages (like mine) to work with tabs across shiny and shiny dashboard in a generic way (see https://github.com/carlganz/rintrojs/blob/master/inst/javascript/rintro.js#L48)

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

YongbingDing commented 2 years ago

您好，丁永兵已经收到您的邮件，谢谢。