search

rstudio / shinyloadtest

Tools for load testing Shiny applications
https://rstudio.github.io/shinyloadtest
108 stars 22 forks source link

Allow Connect API Key #133

Closed akgold closed 3 years ago

akgold commented 3 years ago

Related https://github.com/rstudio/shinycannon/pull/56

Fixes #135

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

akgold commented 3 years ago

Was just demoing this to the SE team -- one thing popped up -- RStudio Connect provides 2 URLs for each content. There's the one that comes up in your URL bar when you navigate to the content inside the Connect dashboard, and the "content URL" for solo mode.

If you put the former into shinyloadtest with an API key, the system just hangs indefinitely with no error. shinycannon does throw an error 

CONNECT_API_KEY=T5opptrM4yXfOlFwDQwta4qjedebPsQB java -jar target/shinycannon-1.1.0-jar-with-dependencies.jar ../shinyloadtest/recording.log https://colorado.rstudio.com/rsc/connect/#/apps/7278
zsh: bad pattern: https://colorado.rstudio.com/rsc/connect/#/apps/7278

But this error probably could be more friendly/helpful.

I think we should check for the form of the URL (look for a #?) and throw an error.

@schloerke -- see e.g. https://colorado.rstudio.com/rsc/connect/#/apps/7278/access vs https://colorado.rstudio.com/rsc/content/7278 (I've given you access to the app on Colorado RSC if you want to take a look). Want me to make a PR here? I'm less confident of my ability to do so in shinycannon.

schloerke commented 3 years ago

@akgold Issue added: https://github.com/rstudio/shinyloadtest/issues/135