search

rstudio / shinymeta

Record and expose Shiny app logic using metaprogramming
https://rstudio.github.io/shinymeta
223 stars 14 forks source link

Don't formally import styler into NAMESPACE, but use `::` #117

Closed lorenzwalthert closed 6 months ago

lorenzwalthert commented 7 months ago

I am the author of the R package styler, which you use in your code. I repeatedly get strange and hard-to-reproduce reverse dependency errors when submitting a new version of my package to CRAN: Running R CMD CHECK on your package with a new version of {styler} results in problems like https://github.com/HenrikBengtsson/R.cache/issues/51 that I believe could be easily avoided by not importing {styler}. So instead of importing style_text into your NAMESPACE and use style_file() in your source code, you could use styler::style_file() in your source code and not import style_text into your NAMESPACE. I don't believe it would affect the user experience of your package.

Would you be open to that change? It has the potential to save me hours of debugging and stress. 😀

lorenzwalthert commented 7 months ago

{styler} made it to CRAN thanks to wrapping some code in rlang::try_fetch(), which I consider a workaround. So if I was not clear before, the issue is not urgent (anymore), but I'd still appreciate if you would consider making the change.