Unsafe expansion detection

rstudio / shinymeta

Record and expose Shiny app logic using metaprogramming

https://rstudio.github.io/shinymeta

223 stars 14 forks source link

Unsafe expansion detection #92

Closed jcheng5 closed 3 years ago

jcheng5 commented 3 years ago

[x] Either ensure that .rmd is the only template format we support, or, properly support knit_expand_safe for any format we do support.
[x] knit_expand_safe should not read from the parent frame
[x] Show notification to user when buildRmdScript fails in a downloadHandler
[x] Fix tests (styler color codes)

jcheng5 commented 3 years ago

Regarding the first checkbox above, "Either ensure that .rmd is the only template format we support, or, properly support knit_expand_safe for any format we do support":

Yes, it is the only template format we currently support due to https://github.com/rstudio/shinymeta/blob/07bf34ed3b0186f07ac5100aab023c47b63127ed/R/report.R#L65 being hardcoded to "Rmd".

cpsievert commented 3 years ago

Proposed fix for the last item https://github.com/rstudio/shinymeta/pull/93