search

rstudio / shinytest

Automated testing for shiny apps
https://rstudio.github.io/shinytest/
Other
225 stars 55 forks source link

improve little bits for in-pkg use #396

Closed maxheld83 closed 3 years ago

maxheld83 commented 3 years ago
CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

maxheld83 commented 3 years ago

Maybe we make a second folder tree after the tests have been created? We could keep the first tree as it originally was.

will do

maxheld83 commented 3 years ago

Going over the trees again, it occurs to me that there are really two sets of questions at play:

  1. the location of the app in the package a. /inst b. /R (some function returns a shinyApp()object)
  2. what style of testing to use a. using snapshots (the shinytest way): your inputs and outputs exist in xxx.json b. roll your own app <- ShinyDriver$new() (the testthat way) as explained in mastering-shiny: your inputs and outputs exist right in test_that({}.

Parts of the tree only pertain to / result from 2a.

I can try and restructure the vignette along these differences, perhaps linking out for some details to mastering-shiny.

Otherwise, I think the original, unchanged trees make more sense and I'll close this.

schloerke commented 3 years ago

This is the shinytest package, so 2a makes a lot of sense.

I'd be grateful if you can hold the energy and put it towards shinytest2 in a few weeks. shinytest2 will be integrated with testthat ed3 snapshots and move away from the ./tests/shinytest folder.