Sort second level keys. Forces `input`/`output`/`export` to be consistently ordered

schloerke commented 3 years ago

Fixes #409

@LamaTe Could you try this branch out to see if it fixes your situation? Thank you!

remotes::install_github("rstudio/shinytest#415")

bersbersbers commented 3 years ago

I have the same problem as #409. But after remotes::install_github("rstudio/shinytest#415"), my checks are not finishing any more:

> shinytest::testApp("inst/shiny")
Running some_check.R Error: lexical error: invalid char in json text.
                                       character(0)
                     (right here) ------^

The same is not happening following remotes::install_github("rstudio/shinytest"). I also double-checked

git clone https://github.com/rstudio/shinytest.git
cd shinytest
git checkout v1.5.1
git cherry-pick 2716b05 4bf6914
R -e "devtools::install()"

and the same thing is happening; next try,

git checkout v1.5.1
R -e "devtools::install()"

and tests are passing. So this PR seems to be missing some edge case.

bersbersbers commented 3 years ago

The above seems to be the same problem as in https://github.com/rstudio/shinytest/pull/415/checks?check_run_id=3680356347

schloerke commented 3 years ago

Thank you @bersbersbers ! Looking into it...

schloerke commented 3 years ago

Closing PR (as it is not a fix) and moving conversation back to #409

rstudio / shinytest

Sort second level keys. Forces `input`/`output`/`export` to be consistently ordered #415