search

rstudio / shinytest

Automated testing for shiny apps
https://rstudio.github.io/shinytest/
Other
225 stars 55 forks source link

Support HTTP authentication in URLs #427

Closed bersbersbers closed 2 years ago

bersbersbers commented 2 years ago

@schloerke, https://github.com/rstudio/shinytest/pull/348#issuecomment-1039488132

Adding support for the user/pass in the url string is very reasonable. A small PR for this logic would be great!

Here you go. I did wonder why parse_url() and sd_getShinyUrl() don't use httr::parse_url() and httr::build_url().

bersbersbers commented 2 years ago

I included one more patch for URLs without an explicit port.

schloerke commented 2 years ago

@bersbersbers Can you add a NEWS entry, please? Then I'll merge 😃 . Thank you!

I did wonder why parse_url() and sd_getShinyUrl() don't use httr::parse_url() and httr::build_url().

🤷‍♂️
I'll be sure to have shinytest2 have user / pass support.

bersbersbers commented 2 years ago
  • [x] NEWS entry

Done. It feels a bit odd to list changes to an undocumented feature, but why not ;)